Skip to content

hack/ci: pass --remote to bud tests - #29529

Merged
Luap99 merged 2 commits into
podman-container-tools:mainfrom
vtushar06:fix-bud-remote-mode
Aug 17, 2026
Merged

hack/ci: pass --remote to bud tests#29529
Luap99 merged 2 commits into
podman-container-tools:mainfrom
vtushar06:fix-bud-remote-mode

Conversation

@vtushar06

Copy link
Copy Markdown
Contributor

The bud remote job runs the same local binary as bud local. Both jobs from run 31847250452 on main print the identical bats invocation:

sudo env TMPDIR=/var/tmp PODMAN_BINARY=/var/tmp/podman-container-tools/podman/bin/podman PODMAN_SERVER_LOG= REMOTE= ...

bin/podman, not podman-remote, and REMOTE= empty, in the job named remote.

The remote path in run-buildah-bud-tests is gated on PODBIN_NAME (line 78), which Cirrus used to set per matrix task. The migration replaced that with a mode: matrix key, but run_bud() never reads $MODE - run_int, run_sys, run_machine and run_upgrade all do. grep -rn PODBIN_NAME outside vendor finds it only inside run-buildah-bud-tests itself and in the treadmill script's Cirrus text.

So apply-podman-deltas has 30 skip_if_remote and 4 skip_if_rootless_remote entries that are currently no-ops, and podman-remote build coverage has been off since the migration.

--remote is already an option on the script and sets PODBIN_NAME=remote before that gate, so this is one branch in run_bud.

Worth saying plainly: this restores coverage rather than being a no-op, so the remote leg may go red on things that have been hidden. Most of the historically broken ones should already be covered by those deltas, but if new failures show up I am happy to iterate on them here or in a follow-up.

@github-actions github-actions Bot added the CI label Aug 15, 2026

@Luap99 Luap99 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think passing --remote makes sense but since we no longer set PODBIN_NAME I would usggest you drop that from the script and just use REMOTE/PODMAN_BINARY env there.

Signed-off-by: Tushar Verma <tusharmyself06@gmail.com>
Signed-off-by: Tushar Verma <tusharmyself06@gmail.com>
@vtushar06
vtushar06 force-pushed the fix-bud-remote-mode branch from e2ca3d0 to de8c356 Compare August 17, 2026 11:00
@vtushar06

vtushar06 commented Aug 17, 2026

Copy link
Copy Markdown
Contributor Author

okay dropped it. @Luap99

now only PODBIN_NAME left is the cirrus yaml text in hack/buildah-vendor-treadmill, left that alone

@Honny1 Honny1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Luap99 Luap99 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Luap99
Luap99 enabled auto-merge August 17, 2026 12:35
@Luap99
Luap99 merged commit 0c5e084 into podman-container-tools:main Aug 17, 2026
127 of 129 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants